search

stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
323 stars 33 forks source link

Legacy formatted text has delimiters in the final text #81

Closed stackotter closed 2 years ago

stackotter commented 2 years ago

Describe the bug Somehow the delimiters are making it into the NSAttributedString I think

To Reproduce Steps to reproduce the behavior:

  1. Add Hypixel to the server list
  2. View the ping result
  3. The description is formatted weirdly (see image below)

Expected behavior The text would be formatted correctly

Screenshots

Screen Shot 2022-02-04 at 07 50 16

The issue doesn't seem to happen for all legacy styled text though, I'm pretty sure the blue text in the image below is also legacy formatted text but it doesn't have the issue: Screen_Shot_2022-02-04_at_07 52 26

Extra information (please complete the following information

AlbertoSamele commented 2 years ago

Will fix this

stackotter commented 2 years ago

I rewrote the legacy formatted text implementation to clean it up and it works correctly now