stacks-network / stacks-core

The Stacks blockchain implementation
https://docs.stacks.co
GNU General Public License v3.0
3.01k stars 667 forks source link

feat: Signer signature count endpoint #5153

Closed jbencin closed 5 days ago

jbencin commented 3 weeks ago

Description

Add RPC endpoint /v3/signer/{signer_pubkey}/{reward_cycle} that returns number of blocks signed by signer during given reward cycle

Applicable issues

Additional info (benefits, drawbacks, caveats)

Someone with more experience with chainstate DB and SQL in general please double-check the schema migration and queries

Progress

Checklist

CLAassistant commented 1 week ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: jbencin
:white_check_mark: kantai
:white_check_mark: jcnelson
:white_check_mark: saralab
:white_check_mark: obycode
:x: jferrant
You have signed the CLA already but the status is still pending? Let us recheck it.

jbencin commented 1 week ago

but can you also add unit tests for the new handler. Each handler has a corresponding bundle of unit tests in stackslib/src/net/api/tests/

Sure, didn't know about these

jferrant commented 1 week ago

but can you also add unit tests for the new handler. Each handler has a corresponding bundle of unit tests in stackslib/src/net/api/tests/

Sure, didn't know about these

I added one @jbencin . Just relax and enjoy your time away! If @jcnelson needs further testing I can do :)