Refactor NavigationState.navigating tuple to a Struct

[michaelkirk]

No behavioral change here, but I think this is a little nicer. Take it or leave it - no big deal.

[michaelkirk]

I'm sorry, but I don't immediately understand the CI failure: https://github.com/stadiamaps/ferrostar/actions/runs/11187948122/job/31105894502?pr=286

Started: bash /Users/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/entrypoint.sh
INPUT_REPOSITORY value: .
INPUT_STATUS_OPTIONS: 
INPUT_FILE_PATTERN: apple/Sources/UniFFI/*
INPUT_BRANCH value: mkirk/refactor-tuple-struct
From https://github.com/stadiamaps/ferrostar
 * [new branch]      autocomplete-search -> origin/autocomplete-search
 * [new branch]      dependabot/gradle/android/agp-8.7.0 -> origin/dependabot/gradle/android/agp-8.7.0
 * [new branch]      feat/android/android-auto-init -> origin/feat/android/android-auto-init
 * [new branch]      feat/ios-speed-limit-view -> origin/feat/ios-speed-limit-view
 * [new branch]      main                -> origin/main
 * [new tag]         0.17.0              -> 0.17.0
fatal: invalid reference: mkirk/refactor-tuple-struct
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/Users/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 128
}
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/Users/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

It appears that it's looking for my branch in your repository? That seems like it'd break for any foreign PR, but maybe I'm misreading.

Here's my last PR, where the same step succeeded: https://github.com/stadiamaps/ferrostar/actions/runs/11018872003/job/30600115747

Notably the INPUT_BRANCH line is not present.

[ianthetechie]

I'm sorry, but I don't immediately understand the CI failure: https://github.com/stadiamaps/ferrostar/actions/runs/11187948122/job/31105894502?pr=286

@michaelkirk yeah, I know what happened. And I was wondering if we'd hit that error at some point 😂 Yay for untestable automation tools...

TL;DR make sure you run build_ios.sh, that Package.swift does not have local framework flags enabled, and that you've run swiftformat.

We have a CI action that automatically fixes these, but apparently this doesn't work cross-org even though you gave maintainers access to make changes.