stadiamaps / ferrostar

A FOSS navigation SDK built from the ground up for the future
https://stadiamaps.github.io/ferrostar/
Other
184 stars 24 forks source link

Apple Annotation parsing #287

Closed Archdoog closed 1 month ago

Archdoog commented 1 month ago

271 for iOS

ianthetechie commented 1 month ago

FYI @Patrick-Kladek @engali94. I know that you had a PR that I think is semi-blocked on this (#293). Feedback welcome.

engali94 commented 1 month ago

@ianthetechie I believe the new implementation by @Archdoog is more flexible and serve the purpose well. I am going to close my pr in favor of this implementation. Do we have something similar for Android?

ianthetechie commented 1 month ago

Sounds good, @engali94! Thanks for the review!

Re: Android, we don't have a PR yet, but I think you're more than welcome to tackle it.

I think that the closest thing to this which we have to Codable in Kotlin is the kotlinx.serialization library (but don't take that as absolute truth; I'm a much stronger Swift developer than Kotlin).

@Archdoog anything you want to add before the HudHud team takes a crack at it?

Archdoog commented 1 month ago

Sounds good, @engali94! Thanks for the review!

Re: Android, we don't have a PR yet, but I think you're more than welcome to tackle it.

I think that the closest thing to this which we have to Codable in Kotlin is the kotlinx.serialization library (but don't take that as absolute truth; I'm a much stronger Swift developer than Kotlin).

@Archdoog anything you want to add before the HudHud team takes a crack at it?

I'll write up the Android ticket(s) and follow up iOS ticket for traffic congestion ticket once we merge this so I can link and reference to things.