search

stakes / Frameless

A chromeless web browser for viewing prototypes.
MIT License
643 stars 74 forks source link

Fixed crash when opening settings on iPad #36

Closed jaanus closed 9 years ago

jaanus commented 9 years ago

Observed behavior

Tapping the settings button is crashing in all cases where the horizontal size class is Regular (all iPads, and iPhone 6+ in landscape).

Expected behavior

Obviously, shouldn’t crash.

Notes

Maybe a nicer fix can be done that preserves the animation, but I couldn’t immediately find out what was going on. Stack trace was all about UIKit internals and feels like this kind of presentation is just pooping on itself in this situation. So, disabled the presentation animation until the root cause of the crash is found, so that at least the app keeps working and you can change settings in these cases.

stakes commented 9 years ago

Awesome. I will take a look and merge in the next couple of days!

stakes commented 9 years ago

:+1: thanks!