stamatak / ExaML

Exascale Maximum Likelihood (ExaML) code for phylogenetic inference using MPI
49 stars 24 forks source link

correct an undefined behavior (fails in GCC 4.8.1 with -O2) #6

Closed kazcw closed 8 years ago

kazcw commented 10 years ago

The type of protModels is not consistent between files, causing undefined behavior leading to crashes under certain circumstances. For detail see thread here: http://www.reddit.com/r/programming/comments/257dn6/the_compiler_is_always_right_nathans_blog/cheq5pw

stamatak commented 10 years ago

Many thanks for spotting this, just fixed it :-)

Alexis

PS: Andre, please correct this in the new ExaML release we are preparing as well.

On 05/11/2014 12:11 AM, kazcw wrote:

The type of protModels is not consistent between files, causing undefined behavior leading to crashes under certain circumstances. For detail see thread here: http://www.reddit.com/r/programming/comments/257dn6/the_compiler_is_always_right_nathans_blog/cheq5pw You can merge this Pull Request by running:

git pull https://github.com/kazcw/ExaML master

Or you can view, comment on it, or merge it online at:

https://github.com/stamatak/ExaML/pull/6

-- Commit Summary --

  • correct an undefined behavior (fails in GCC 4.8.1 with -O2)

-- File Changes --

 M parser/parsePartitions.c (2)

-- Patch Links --

https://github.com/stamatak/ExaML/pull/6.patch https://github.com/stamatak/ExaML/pull/6.diff


Reply to this email directly or view it on GitHub: https://github.com/stamatak/ExaML/pull/6

Alexandros (Alexis) Stamatakis

Research Group Leader, Heidelberg Institute for Theoretical Studies Full Professor, Dept. of Informatics, Karlsruhe Institute of Technology Adjunct Professor, Dept. of Ecology and Evolutionary Biology, University of Arizona at Tucson

www.exelixis-lab.org