stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.61k stars 369 forks source link

CI to use python3 on the mac instances #3128

Closed serban-nicusor-toptal closed 2 years ago

serban-nicusor-toptal commented 2 years ago

Submission Checklist

Summary

See: https://github.com/stan-dev/performance-tests-cmdstan/pull/41

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

serban-nicusor-toptal commented 2 years ago

Hey @WardBrian do we need python3 in the Mac Unit too ?

WardBrian commented 2 years ago

I don’t believe so, only the performance tests have changed

WardBrian commented 2 years ago

It looks like Jenkins isn't queuing new jobs pending a restart, but the currently running Math/develop job is preventing it from restarting. Do we want to kill the math develop job and restart it later, or let Jenkins queue for a day?

serban-nicusor-toptal commented 2 years ago

Jenkins is going to shut down for maintenance at Flatiron so I think the queued jobs will not be executed until it's back online anyway.

WardBrian commented 2 years ago

The relevant tests are now passing. The failure was due to a merge in stanc before math had a chance to percolate up (math also had some weird CI failures)