stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.61k stars 369 forks source link

Use the new get_param_names bool arguments in initialize #3138

Closed SteveBronder closed 1 year ago

SteveBronder commented 2 years ago

Submission Checklist

Summary

Uses https://github.com/stan-dev/stanc3/pull/1241 to get back only the parameter names when setting initial values, Fixes https://github.com/stan-dev/stanc3/issues/1240 so that when the user specifies initial values they are only run once.

This PR will fail until https://github.com/stan-dev/stanc3/pull/1241 is merged

Intended Effect

Fixes https://github.com/stan-dev/stanc3/issues/1240

How to Verify

Do I need additional tests for this? I'm not sure what kind of test we would want.

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

WardBrian commented 2 years ago

Oh, I put together https://github.com/stan-dev/stan/pull/3139 to do the same thing.

These need to be arguments to the existing function, not a new overload, or else model.get_param_names(vec) becomes ambiguous and fails to compile

WardBrian commented 1 year ago

Subsumed by #3139