Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
Fixes #3241 by just removing the line that adds back the max log likelihood ratio
Submission Checklist
[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below
Summary
Intended Effect
How to Verify
Should we have tests for this? This just seemed like a numeric bug inside of the function so I'm not sure if / how to test this
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Flatiron Institute
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
it seems you also dropped the normalization, which is ok, if boost is accepting unnormalized weights
it seems you also changed how the truncation is done, by using a one-liner instead of for loop, and as I'm not familiar with the syntax, I'm not able to verify that it does the same thing, but I assume you know it's the same
Fixes #3241 by just removing the line that adds back the max log likelihood ratio
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Intended Effect
How to Verify
Should we have tests for this? This just seemed like a numeric bug inside of the function so I'm not sure if / how to test this
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Flatiron Institute
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: