stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.56k stars 366 forks source link

update psis to not add back the max and return the unnormalized resample ratios #3243

Closed SteveBronder closed 7 months ago

SteveBronder commented 8 months ago

Fixes #3241 by just removing the line that adds back the max log likelihood ratio

Submission Checklist

Summary

Intended Effect

How to Verify

Should we have tests for this? This just seemed like a numeric bug inside of the function so I'm not sure if / how to test this

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Flatiron Institute

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

avehtari commented 8 months ago

Fixes https://github.com/stan-dev/stan/issues/3241 by just removing the line that adds back the max log likelihood ratio