search

stanaka / dash-at-point

a emacs lisp for searching the word at point with Dash
388 stars 32 forks source link

New way for plugins to call Dash with keywords #14

Closed Kapeli closed 10 years ago

Kapeli commented 10 years ago

Dash 1.9.3 comes with a new way for plugins to call Dash and send over a list of keywords which Dash uses to enable/disable docsets.

This is all described at http://kapeli.com/dash_plugins.

In the next weeks I'll go through all plugins and update them myself, so expect a pull request regarding this. However, if you have some free time and want to do it yourself, feel free to do so :+1:.

Note: please do not release a new version of the Emacs plugin for at least 2-4 weeks, so that Dash users have time to update to 1.9.3.

stanaka commented 10 years ago

The new way is very attractive!

Kapeli commented 10 years ago

@stanaka can you add support for this? I tried, but Emacs Lisp is really really confusing for me...

stanaka commented 10 years ago

I've just implemented it! Please try it.

For users use old versions of Dash, I provides a customize option to call Dash with legacy way (dash://)

Kapeli commented 10 years ago

Looks good. One issue: you're not percent escaping the query. This means that if the user tries to search for something that contains a &, things will break.

Thanks a lot for taking the time to add this!

stanaka commented 10 years ago

Oops, I fixed it. Thanks!

yasuyk commented 10 years ago

@Kapeli @stanaka Great! I have wanted this feature for a long while! Thanks! ;-)