Closed romkhub closed 1 year ago
š Thanks for opening this pull request! You're awesome.
Should work to just use the ignore flag in installed-check to have it ignore dependency-check, the dev deps are not as crucial and dependency-check will quit silently on unsupported node versions
Thank you @voxpelli done!
š Congrats on getting your first pull request landed!
Good day
Thank you a lot for accepting this PR
Could I kindly ask anyone to release the 15.1.0
version?
@voxpelli @Divlo @LinusU sorry for bothering, could you please help releasing this?
I'll try to get to it next week, I'm crunching g towards a Christmas deadline right now, if it hasn't been released by next week, then ping me here again
(I want GitHub to add a snooze feature š)
friendly ping @voxpelli
friendly ping @voxpelli ā¤ļø
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [ ] Bug fix [x] New feature [ ] Other, please explain:
What changes did you make? (Give an overview) Added
--ignore
flag support. I'd like to run linter separately for unit-tests:Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on? I had to change
engines
setup inpackage.json
becausecheck:installed-check
script fails otherwise:this comes from the following
dependency-check
commit - https://github.com/dependency-check-team/dependency-check/commit/e88ae34537ee9dadbf472ffe7b32285f90fd99ebI'd love to see this feature within the current major version, but I doubt this is going to be blessed due to drop of node-12. Is there an option to avoid a major version bump, or should I just go ahead and make it
"version": "16.0.0"
?