standard / standard-engine

:fire_engine: The guts of `standard` modularized for reuse
MIT License
146 stars 39 forks source link

feat(cli): add `--ignore` option #317

Closed romkhub closed 1 year ago

romkhub commented 1 year ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [x] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Added --ignore flag support. I'd like to run linter separately for unit-tests:

"lint:src": "ts-standard src -p tsconfig.json --ignore \"src/**/*.test.ts\"",
"lint:unit": "ts-standard \"src/**/*.test.ts\" -p tsconfig.test.json",

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on? I had to change engines setup in package.json because check:installed-check script fails otherwise:

-    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
+    "node": "^14.18.0 || >=16.0.0"

this comes from the following dependency-check commit - https://github.com/dependency-check-team/dependency-check/commit/e88ae34537ee9dadbf472ffe7b32285f90fd99eb

I'd love to see this feature within the current major version, but I doubt this is going to be blessed due to drop of node-12. Is there an option to avoid a major version bump, or should I just go ahead and make it "version": "16.0.0"?

welcome[bot] commented 1 year ago

šŸ™Œ Thanks for opening this pull request! You're awesome.

voxpelli commented 1 year ago

Should work to just use the ignore flag in installed-check to have it ignore dependency-check, the dev deps are not as crucial and dependency-check will quit silently on unsupported node versions

romkhub commented 1 year ago

Thank you @voxpelli done!

welcome[bot] commented 1 year ago

šŸŽ‰ Congrats on getting your first pull request landed!

romkhub commented 1 year ago

Good day Thank you a lot for accepting this PR Could I kindly ask anyone to release the 15.1.0 version?

romkhub commented 1 year ago

@voxpelli @Divlo @LinusU sorry for bothering, could you please help releasing this?

voxpelli commented 1 year ago

I'll try to get to it next week, I'm crunching g towards a Christmas deadline right now, if it hasn't been released by next week, then ping me here again

(I want GitHub to add a snooze feature šŸ˜)

theoludwig commented 1 year ago

friendly ping @voxpelli

romkhub commented 1 year ago

friendly ping @voxpelli ā¤ļø

voxpelli commented 1 year ago

Released in 15.1.0, thanks šŸ™