search

standard / ts-standard

Typescript style guide, linter, and formatter using StandardJS
https://www.npmjs.com/package/ts-standard
MIT License
464 stars 36 forks source link

chore(build): allow installing from git to work #173

Closed mcfedr closed 3 years ago

mcfedr commented 3 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [X] Other, please explain:

What changes did you make? (Give an overview)

Move the husky install command to prepare - this is the recommended place to put it with newer husky docs. This means it wont be run when the package is installed, and pinst is no longer needed

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

mcfedr commented 3 years ago

@Divlo would be great to stick this in the "upcoming" 11 release as well.

mcfedr commented 3 years ago

Oh weird, I looked at https://www.npmjs.com/package/husky - > under usage

mcfedr commented 3 years ago

wait - in the npm section - it talks about prepare - https://typicode.github.io/husky/#/?id=install - and also see the comments about prepare in npm doc- https://docs.npmjs.com/cli/v7/using-npm/scripts#prepare-and-prepublish

Really we if to start changing stuff, I'd remove the dist folder from git and use prepare with tsc

theoludwig commented 3 years ago

wait - in the npm section - it talks about prepare - typicode.github.io/husky/#/?id=install - and also see the comments about prepare in npm doc- docs.npmjs.com/cli/v7/using-npm/scripts#prepare-and-prepublish

Really we if to start changing stuff, I'd remove the dist folder from git and use prepare with tsc

I guess it's fine like that, it does the job. :+1:

Oh weird, I looked at npmjs.com/package/husky - > under usage

Yes, that's how to use husky for projects, not for npm packages.