search

stanfordnlp / CoreNLP

CoreNLP: A Java suite of core NLP tools for tokenization, sentence segmentation, NER, parsing, coreference, sentiment analysis, etc.
http://stanfordnlp.github.io/CoreNLP/
GNU General Public License v3.0
9.69k stars 2.7k forks source link

Integration of Mocking framework #1022

Open jvdassen opened 4 years ago

jvdassen commented 4 years ago

Hello everyone, first off thank you for this project!

We are a group of students aiming at contributing more unit tests to this project. Thus we have read and acknowledged the contribution rules. During our analysis of the project we found different units that are hard to test since they depend on complex input objects, such as for example Files.

Would the maintainers of this project accept a pull request where the Mockito library is integrated into the testing procedures to cover things that are hard to test and have 0% test coverage at the moment? Looking at the licensing requirements of this project and the license of Mockito (MIT license) we assume that it would be compatible.

AngledLuffa commented 4 years ago

In general we try to avoid expanding the library footprint of corenlp. Do you have a few suggestions of classes you want tested more thoroughly?