search

stanfordnlp / CoreNLP

CoreNLP: A Java suite of core NLP tools for tokenization, sentence segmentation, NER, parsing, coreference, sentiment analysis, etc.
http://stanfordnlp.github.io/CoreNLP/
GNU General Public License v3.0
9.65k stars 2.7k forks source link

HTML, CSS and .js files associated with demo not copied by Github build. #1209

Open cbrew opened 2 years ago

cbrew commented 2 years ago

It would be nice if the Maven command that builds from source automatically copied /demo/corenlp-brat.html, /demo/corenlp-brat.css, /demo/corenlp-brat.js and /demo/corenlp-parseviewer.js into the same place that they appear in a release. Because that doesn't yet happen, the server doesn't find what it is looking for , and falls older versions of the files from some non-obvious (and, I think remote) place. The effect is that the website claims to be 4.2.0 no matter what, and doesn't have the spiffy logo.

AngledLuffa commented 2 years ago

Do you have any suggestions or possibly a pull request?

cbrew commented 2 years ago

Haven't found an easy fix yet. will submit pull request if I do.

J38 commented 2 years ago

Do you mean using the "Build with Maven" instructions on the front page?

cbrew commented 2 years ago

yeah.

On Sun, Oct 24, 2021 at 5:17 AM J38 @.***> wrote:

Do you mean using the "Build with Maven" instructions on the front page?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stanfordnlp/CoreNLP/issues/1209#issuecomment-950289799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFIW2SERMTPDFOXEP2YUDLUIPFIVANCNFSM5GOBH5HQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

AngledLuffa commented 2 years ago

Maybe this will help?

https://github.com/stanfordnlp/CoreNLP/commit/c8909a9ef8fe22e1833dc36ac3a1ab7cc8d1ee1a