search

stanfordnlp / python-stanford-corenlp

Python interface to CoreNLP using a bidirectional server-client interface.
MIT License
516 stars 105 forks source link

Setting properties in CoreNLPClient.annotate() #24

Closed adrianjellis closed 5 years ago

adrianjellis commented 6 years ago

The logic appears to be incorrect when the properties argument is not None in the annotate() call. It looks like this line should be outdented. Workaround is to set properties when instantiating CoreNLPClient instead.

arunchaganty commented 5 years ago

Ah the current logic is that when you specify properties as an argument to annotate, it is used instead of the default properties as opposed to being merged / updated from the default properties.