search

stangreg / Ignitron

An ESP32 based foot pedal to control the Spark Amp and connect to the App using Bluetooth LE.
BSD 3-Clause "New" or "Revised" License
35 stars 11 forks source link

20240124 blekeyboard improvement #27

Closed itarozzi closed 5 months ago

itarozzi commented 5 months ago

Advanced mapping for BLEKeyboard mode.

I can now map, for each button, also special keys (defined in https://github.com/T-vK/ESP32-BLE-Keyboard/blob/master/BleKeyboard.h). For each button I can also add a modifiers (shift, ctrl, alt) and repeat for n times.

itarozzi commented 5 months ago

I would like to do the same for Looper Mode. Do you think is better work on other branch ?

Or, if you merge this PR, I can create a new PR in the future from the same branch? Never done before

stangreg commented 5 months ago

@itarozzi I also have never done this before. I understood that I need to review and test in my repository and if approved, the change will be merged into my repository. My understanding would be that you can continue to develop on the same branch if you prefer, you can create another pull request later on this one. I need to check in the next days when I have some time to check and approve. I will keep you updated here.