staniel359 / muffon

Advanced multi-source music streaming + discovery client for desktop. Free, clean, no login, no ads.
https://muffon.netlify.app
GNU Affero General Public License v3.0
1.36k stars 58 forks source link

Autoplay after restarting not working #201

Open roloit opened 1 month ago

roloit commented 1 month ago

Hi, great app!!!

There's this thing, I don't know if it's on all platforms, but it's definitely on macOS. When you are streaming music from deezer, but then close the app, like close completely, and then open it up, the last played track is still in the bar, but the play button is outlined gray, it doesn't autoplay, and you can't even click the play button on it, you have to manually click next track, then back again, and then it works (I observed that other streaming platforms don't autoplay, also, but you can resume the playback).

I think it would be great if you add an option in the settings: "Resume playback on app boot" or something. Also, somehow the clear history/cache buttons don't clear the search history. Thanks!

staniel359 commented 1 month ago

@roloit Hello. Thank you for the kind words! We humbly welcome you to the muffon community.

This is actually a known bug regarding expiring audio links. What basically happens is the audio files that are created on our server to serve the audios are removed every 3 hours to save storage. So after 3 hours, the player is referencing to nonexistent audio links.

The bug fix is planned.

xyloflake commented 1 month ago

@staniel359 what about "search history removal"?

staniel359 commented 1 month ago

@xyloflake Right, thanks.

@roloit

Also, somehow the clear history/cache buttons don't clear the search history

Works for me. Could you attach a video of this behavior?

roloit commented 1 month ago

Um, about the search history clearing, I actually just found it in settings, it's just in a different section, it works 👍 Little suggestion for the link-expiration thing: maybe you could make the player to cache the last played second of the last played song, for if I just reboot, or return to my pc after a few minutes, for example. But I suppose that the problem there is how to make the app to request the new link of the song if it already cached the expired link? Maybe set a 3 hour maximum limit for that feature? Also, why does the Spotify playback limit to 29 seconds if the Spotify api is connected to an account, as I understand, because the 29 seconds limit is for link embeds, as I understand?

staniel359 commented 1 month ago

@roloit I'll see what could be done.

Also, why does the Spotify playback limit to 29 seconds if the Spotify api is connected to an account, as I understand, because the 29 seconds limit is for link embeds, as I understand?

No, it's not that. It just breaks sometimes because of their security system.

xyloflake commented 1 month ago

Little suggestion for the link-expiration thing: maybe you could make the player to cache the last played second of the last played song, for if I just reboot, or return to my pc after a few minutes, for example. But I suppose that the problem there is how to make the app to request the new link of the song if it already cached the expired link? Maybe set a 3 hour maximum limit for that feature?

Hmm... I can actually think of yet another logic but it will require updation of the entire backend audio fetching logic. I'll give it a deeper thought later.