Fixed #9

[Lonami]

However, perhaps we do need to bring back the MOVE_THRESHOLD. It's a bit hard not to move the finger at all ;)

[stanipintjuk]

Great! you fixed it!

Only problem is that no touch events fall through to the widget, so it is impossible to click or swipe on the widget. And this is the problem

return true; // TODO I'm not sure whether false or true make any difference here

It has to return false otherwise no touch events would fall through to the widget.

I have tested it with return false; and it still works great, and it is possible to click and swipe the widgets.

Please make it return false, then squash the commits, and force push so that the PR gets updated.

Then I will merge.

Well done!

[Lonami]

Okay, thanks for explaining about the return. I thought it was the other way round or something, but couldn't see the difference :P

[stanipintjuk]

If we bring back the MOVE_THRESHOLD then we would have to create our own definition of what an actual "finger swipe" or "finger movement" is, and answer question like "what is the speed limit of a move action", "what is the theshold limit of a move action?", "Do these variables vary from resolution to resolution and dpi to dpi?".

By using ACTION_MOVE we can use the defintion that is already defined by the android system and we don't have to worry about these questions. And this will make our interface not only consistent witht the rest of the system, but also consistent across different devices, with different screen sizes, resolutions, dpi:s etc.

... at least in theory...

[stanipintjuk]

Awesome

But could you squash your commits (here is a tutorial if you don't know how to do it) so that we don't have these tiny-tiny-commits please?

[Lonami]

OK, thanks for the tutorial, but now I have 3 commits, this will take some time...

[Lonami]

I think I had to git pull your README.md update but I was kind of scared because I wasn't sure of what that would've been... So I just git push --force. All done now? This is a bit embarrassing and everything in GitHub has to be public 🙈

[stanipintjuk]

Lol don't worry, you did well

[Lonami]

About the MOVE_THRESHOLD, if we implemented something it would be on top of the ACTION_MOVE, this is, we would only be extending (instead of cancelling on the smallest movement, we could add a little offset for it to be easier, or perhaps even a "speed of change" (since the last even to the current, how much it changed?). But yes, it would probably be dependant on the screen DPI. However the speed limit or threshold value is easy to answer, there's no "absolute answer", only one that fits well :)

[stanipintjuk]

Ok I think that I understand what you are saying. But I don't think that it is a problem to hold the finger still for a bit. If it bothers you then you are welcome to patch it. And if your patch works good on multiple devices then I might merge it. I will not waste time on this issue though, because it doesn't bother me