search

stanipintjuk / Silverfish

A simple and lightweight launcher for Android.
GNU General Public License v3.0
44 stars 17 forks source link

Rewrite of TabbedAppDrawerFragment. #18

Closed stanipintjuk closed 8 years ago

stanipintjuk commented 8 years ago

Devided it into 2 different classes, and added a class for tab and the fragment information. Most important thing to note is that tab id and the tab index are no longer related, so it should be easer to add and remove tabs.

Would be nice if e.g. @XyLoNaMiyX could take a quick glance and tell me if a missed something.

Lonami commented 8 years ago

Yay! Testing time! :) Let's see let's see.

Lonami commented 8 years ago

You've done a good job. It's much cleaner now! And I'm glad you fixed those annoying parts which sometimes added or subtracted 1 magically.

stanipintjuk commented 8 years ago

Woops :P

Yeah it was really annoying and confusing. I have no idea what I was thinking when I originally wrote it