stanipintjuk / Silverfish

A simple and lightweight launcher for Android.
GNU General Public License v3.0
44 stars 17 forks source link

Limit tab width #23

Open Lonami opened 8 years ago

Lonami commented 8 years ago

Steps to reproduce

Enter a veeeery long tab name

What should happen

The name should expand among different lines

What actually happens

The tabs stretch the icons a lot and/or hide them totally

Lonami commented 8 years ago

Oh also the tab name should be trimmed. I find it a non-sense to enter " tab name " as a tab name (and that it actually works)

Lonami commented 8 years ago

Can't edit since I'm on phone. There were many spaces between the quotes and "tab name" which GitHub removed.

CrimsonFork commented 7 years ago

Wellm I don't think that "tab name" is really a nonsense. At least not more than "hUyUg6h8(".

Actually "tab mame" could make some sense as a placeholder, fo example: If the device is being shared between Alice, Bob, Celia, David and Felix their tabs could be named like "tab Alice", "tab Bob", ... . If it is planned to be shared with someone else too and they don't know his/her name but want to configure it they could just use "tab name".

I know it shouldn't be that useful but why setting limitations like this? Anyone who tries this will know it's purpose, even if it's only the "fun factor".

Lonami commented 7 years ago

Well I don't think that "tab name" is really a nonsense.

I was putting an example, like " Games " instead "Games" (note the spaces between the " and the G). I didn't actually mean to prevent people from using "tab" in their tab names lol ;)

Trimming means that " Games " would become "Games", no matter how many spaces you put at the beginning or end.

CrimsonFork commented 7 years ago

Ok, that makes much more sense for me.

What I've just thought about, is making Silverfish much more interesting by adding (lots/) some easter eggs for strings like "Silverfish" or "tab" with some type of reactions (in worst case refusing if you type a bad expression).

What do you guys think?