search

stanipintjuk / Silverfish

A simple and lightweight launcher for Android.
GNU General Public License v3.0
44 stars 17 forks source link

Added Bulgarian translation #35

Closed ImAnnoying closed 8 years ago

Lonami commented 8 years ago

Thanks! My pull request hasn't yet been merged, but it has another string. Could you please provide a translation too?

<string name="text_cannot_move_tab">Cannot move this tab</string>
ImAnnoying commented 8 years ago

I'm new to GitHub, how do I do that? :D Or do I just make a new pull request?

Lonami commented 8 years ago

Haha, I was new too. I learnt a lot with this project anyway. Now you should squash those 4 commits into one, not to fill the original project history with unnecessary commits.

  1. First do git rebase -i HEAD~4. This will let you edit the last 4 commits you made.
  2. Then, change pick for squash in those you want to "squash" (those little ones! squash'em'all!)
  3. Then it will ask you for a new commit message. Simply leave "Added Bulgarian translation", since that's all you've done.
  4. Then you need to push your job to GitHub, with probably git push --force since you rebased, so it overrides changes.

But since @stanipintjuk knows more than I, just in case, and if I were you, I would copy the whole folder somewhere else. You know, in case things get screwed up or something.

stanipintjuk commented 8 years ago

More translations, awesome! :)

Everything looks good but as @XyLoNaMiyX said it would be nice if you squashed the commits into one. Here is another guide on how to do it.

Otherwise - well done :)

ImAnnoying commented 8 years ago

I think I did it. Thanks!

Lonami commented 8 years ago

Haha yep! You did it right :). Awesome.

stanipintjuk commented 8 years ago

Thanks! :)