Disable app uninstall when dragging apps above tabs

[DerVerruckteFuchs]

When moving apps to different tabs, dragging an app to the bottom tab can be tricky since the uninstall action shows up with a red highlight and covers part of the bottom of the bottom tab. Disabling the uninstall function when dragging an app above tabs would make working with the bottom tab much easier. Alternatively, moving the drag-to-delete area to a place that's out of the way could work too.

[Lonami]

I think it's a good idea, either don't invoke the uninstall intent if dragging on a tab or...:

[DerVerruckteFuchs]

The corner does seem like a good place. It should be easy enough to uninstall apps one-handed that way. If there was ever an option to line up all apps on the bottom for large screens, the uninstall corner area would need the be moved to the top of course.

[Lonami]

The uninstall corner area could move, but it doesn't have to (in my opinion) even if there were apps below it. If you don't want to uninstall, after the uninstall area pops up, drop the app outside the area and it won't get uninstalled. It will be sorted and placed in the same location as it was before. I would find it annoying to have to move my finger up so high!

Also, having an area which you don't know where it will appear (you do, but it's not something you think about) seems a bit annoying.

[DerVerruckteFuchs]

For big phones, having the uninstall area jump to the top would be a problem. Your idea would seem to work better there, and for most phones really. It would be a little weird to have it under apps, since I'm used to seeing the uninstall area by itself. The automatic alphabetical sorting when dropping apps prevents it from being an issue though.

[stanipintjuk]

I really like your idea Lonami. It is not perfect but it is much better than how it is done right now

[quaap]

FYI: as a test and learning exercise I implemented a version of this. After testing I found the bottom center worked better because on the right edge you could accidentally trigger a return to the homescreen. The dropzone might need to be made bigger, but it works.

You can find it in my fork/branch: https://github.com/quaap/Silverfish/tree/drag-drop-center-delete If you'd like I could start a pull request.

[Lonami]

I like it @quaap, good job! However, there are two little caveats:

1. For me it looks like a rectangle! No gradient, no round shape.
2. Maybe a trash-like icon would look better?

[quaap]

Weird. I could have forgotten to commit something, or maybe it's an API version difference. I'll check it out again later today. Thanks for testing!

[quaap]

I think the problem may have been that I specified the gradientRadius as "100" instead of "100%" in red_gradient.xml. But I'm not sure: the docs are confusing on that point. I've just tested in a low-resolution emulator and it works as expected. When I leave off the "%" is becomes more of a solid rectangle with only a little gradient showing. Pull the latest change and give it a try!

[Lonami]

I think the problem may have been that I specified the gradientRadius as "100" instead of "100%" [...]

Nope. Without the % it does not crash, but it renders a rectangle.

In the android layout preview, with the % it doesn't work; without the % it does render half circle. Awkward.

[quaap]

Strange. I don't receive a crash with the %, and the docs say it's legal. Not sure what's going on here. For whatever reason, your device is reporting the width as zero, and mine isn't. I'll mess around with it again later when my baby naps. Thanks for checking it out.

[stanipintjuk]

Very strange. I can confirm that the red circle looks good on both my Nexus 5X with Android 7 and my Samsung Galaxy Mini with Cyanogenmod 13.0

What phone do you have @XyLoNaMiyX ?

[Lonami]

Sony Xperia M4 Aqua with this ROM, based on AOSP 5.0.

[Lonami]

Alright, I got it working. It's not "100%" but rather... "100%p". Yes, ridiculous.

Edit: I created a PR on your fork, @quaap.