Single tap triggers widget selection

[Lonami]

Steps to recreate

Find a widget which doesn't take all the space in the widget area or one that doesn't take any action. Perform a tap somewhere not occupied by the widget.

What happens

The widget selection triggers.

Proof

• The first tap triggers the widget selection, when it shouldn't
• On the second tap I miss, nothing happens
• On the third tap, even with a little movement, the widget selection triggers
• On the fourth tap, I do hold my finger so you can appreciate the difference

[stanipintjuk]

Can confirm. I tested this with the firefox widget

[Lonami]

Even when onInterceptTouchEvent(MotionEvent ev) (under LauncherAppWidgetHostView.java) returns always false, the widget selection is still triggered. So we probably need to focus on the widget_area FrameLayout instead. Maybe intercept the touch events in a custom way as we did with the widget host view? But that is currently using the default setOnLongClickListener, it should work well... Awkward.

[stanipintjuk]

What if we simply remove any click listeners from the widget_area after a widget has been placed there?

[Lonami]

That's probably a good option.

[stanipintjuk]

Try it. If it works make a PR

[Lonami]

Will play with it ASAP 👍

[Lonami]

It couldn't be that easy... Didn't work. I've added widget_area.setOnLongClickListener(null); on placeWidget(AppWidgetHostView hostView) here and it still fires. Even with a single tap. Isn't that supposed to prevent longClick from being fired?

The problem must be somewhere else.

[Lonami]

This is the responsible. But it shouldn't be the case since it is not a longClick!

[Lonami]

OK, ACTION_UP events are not fired for a simple reason:

If you return false from onTouch method, no further events get delivered to the listener. You should return true at least in case of event.getAction() == MotionEvent.ACTION_DOWN.

From this question. Let's see if that does the trick.