search

starburstdata / metabase-driver

Starburst Metabase driver
Apache License 2.0
65 stars 10 forks source link

AN-633: add optional role field in the connection form #52

Closed lpoulain closed 2 years ago

lpoulain commented 2 years ago

This PR adds a "Role (optional)" field when setting up a connection to Starburst.

As indicated by Piotr, the field entered (when any) is passed as "roles=system:" to the JDBC driver.

If users try to set the role both using that field and the additional JDBC string field, they will get a "Connection property 'roles' is both in the URL and an argument" error

andrewdibiasio6 commented 2 years ago

You should look into the unit tests. I think we already have tests for additional args, maybe you should add some for this field. Take a look.

andrewdibiasio6 commented 2 years ago

Other than my comment about tests, LGTM

andrewdibiasio6 commented 2 years ago

Please squash the commits before merge