search

starburstdata / metabase-driver

Starburst Metabase driver
Apache License 2.0
65 stars 10 forks source link

Refactor the read-column-thunk for Types/TIMESTAMP_WITH_TIMEZONE method #60

Closed lpoulain closed 1 year ago

lpoulain commented 1 year ago

This PR does not change the behavior of the handler but refactors it.

hovaesco commented 1 year ago

Tests are failing

andrewdibiasio6 commented 1 year ago

In general, I am not sure what the goal of this PR is. Is it fixing or related to https://github.com/starburstdata/metabase-driver/pull/60 in any way or is it just a general clean up?

Also, can you squash your commits as well. Looks like there all make changes to the same thing, seems like one commit will do.

lpoulain commented 1 year ago

@andrewdibiasio6 commits squashed. As far as the chances it's a general clean up. I'll let @aalbu comment further.