Enable density detection in DDOS, align memory accesses in Sprow copro #59

stardot / beebem-windows

BBC micro emulator for Windows

http://www.mkw.me.uk/beebem/

Other

90 stars 36 forks source link

Enable density detection in DDOS, align memory accesses in Sprow copro #59 #97

Closed regregex closed 3 years ago

regregex commented 3 years ago

Remove density match check from Type I commands
Add density match check to Read Address command

regregex commented 3 years ago

New commits are added to standing requests? Okay, so Github's not a wiki. Whoops, sorry. Second commit is for #59

chrisn commented 3 years ago

Thanks for contributing these fixes! The typical way to use GitHub is to create a branch for each separate change, then send a pull request for each branch, but it's really not a problem either way.

What should I write in CHANGES.txt for the DDOS fix?

regregex commented 3 years ago

How about:

* Fixed 1770 disk emulation to enable automatic disk density selection
  in Opus DDOS.

So, don't do what I just did: once you've submitted a pull request it'd be rude to continue updating the branch.

Thanks for the tip.

chrisn commented 3 years ago

Perfect, thank you! I'll merge this, unless you have any more changes to make at this stage?

regregex commented 3 years ago

Nope, BeebEm's looking very good to me now! Cheers.