search

starfixdev / starfix

Utility to easily open and operator on source code via url links from your browser
Apache License 2.0
26 stars 21 forks source link

Selective Configuration edit feature added #75

Closed fahad-israr closed 3 years ago

fahad-israr commented 3 years ago
fahad-israr commented 3 years ago

1) When I console a message that "No input provided for Clone Path:Now using Existing/Default Config" shall I also display the config(I am already fetching that from config file)?

2) Also in case there's no config defined we'll be using the default configs(an upcoming feature implemented in PR#71) in which case I will have to display those properties (If we decide to display as mentioned in Point 1) .

fahad-israr commented 3 years ago

@maxandersen I may need your help here. I don't know why the gh-actions is failing. It works locally and also just to verify I pushed it on a separate new repository(https://github.com/fahad-israr/starfix-cli) of mine and it worked there too .

maxandersen commented 3 years ago

@fahad-israr this is conflicting with master - can you update the PR to merge cleanly ?

fahad-israr commented 3 years ago

Sure !! I'll sync with master .

fahad-israr commented 3 years ago

@maxandersen sorry I forgot to add a comment after changes . AFAICR you had already reviewed this previously , there were some merge conflicts . They're fixed now .