stargatedaw / stargate

Innovation-first digital audio workstation (DAW), instrument and effect plugins, wave editor
GNU General Public License v3.0
686 stars 36 forks source link

Add build automation for GitHub Actions #20

Closed psqli closed 3 years ago

ghost commented 3 years ago

Looks good. I had a couple of questions about the setup, also please help me understand what this does. Will it add releases every time I merge something into main? Or where will I be able to download these artifacts?

psqli commented 3 years ago

Looks good. I had a couple of questions about the setup, also please help me understand what this does. Will it add releases every time I merge something into main? Or where will I be able to download these artifacts?

It does not create releases. However, it's possible to add an action that does that. With the current configuration, the build will happen every time a push to main is done or a pull request is opened/synchronized. The artifacts can be downloaded inside the workflow page, in Actions tab.

ghost commented 3 years ago

Looks good, merging. Thanks!

ghost commented 3 years ago

A few issues with this:

Can you please take a look? I'm working on some high severity bugs, I'm not able to spend time on this right now. Thanks!

psqli commented 3 years ago

Can you please take a look? I'm working on some high severity bugs, I'm not able to spend time on this right now. Thanks!

Definitely! I'm curious to know what happened as I've tested it on my previous fork and it was working well.

ghost commented 3 years ago

I am still very interested in having this functionality, but I reverted the original PR for now because I am getting spammed with emails about jobs failing every time I push, and otherwise having the previously mentioned problems with the packaging scripts. Feel free to resubmit once you have it all working.

psqli commented 3 years ago

I am still very interested in having this functionality, but I reverted the original PR for now because I am getting spammed with emails about jobs failing every time I push, and otherwise having the previously mentioned problems with the packaging scripts. Feel free to resubmit once you have it all working.

I've opened PR #23

The jobs fail, I took a quick look but I wasn't sure of the exact cause, seems something to do with what software is available on the build VMs, or else some restriction on internet access, as the Makefile relies on vendoring Python dependencies from the internet using pip

From my description in PR #23:

_The commit 85c3f51 ("Allow building and installing without any vendored dependencies") resulted in Makefile's py_vendor target failing when one of pip install exited with an error. However, pip install was already returning errors. The target all depended on py_vendor, and this ended up failing the build._

Have you experienced the errors after commit 85c3f51?

This broke rpm.py and deb.py when running locally with -i

Now that the build works, do you still have this problem?

dpkg-name does not give the packages a meaningful or useful name, the old way was better, maybe add that --os-name argument to override the generated with name with something else

I used dpkg-name for compliance with Debian format. The idea is to have a .DEB distro-agnostic package.