search

stargatedaw / stargate

Innovation-first digital audio workstation (DAW), instrument and effect plugins, wave editor
GNU General Public License v3.0
686 stars 36 forks source link

Restore PR #20 as the build error is now fixed #23

Closed psqli closed 2 years ago

psqli commented 3 years ago

The commit 85c3f51b74ef1c8f7c91fd7b5b1fade911e770b8 ("Allow building and installing without any vendored dependencies") resulted in Makefile's py_vendor target failing when one of pip install exited with an error. However, pip install was already returning errors. The target all depended on py_vendor, and this ended up failing the build.

The commit c93792e3cefe53507a387e0f6102e79676e568e3 ("Makefile: More modular targets") removed the py_vendor as build dependency. Now the automated build is working again.

psqli commented 3 years ago

For my tests, I've added a commit to disable automatic build on push (f9f68f0cca10e36acfe89dcaf1c2ff4f1ce7c893). With this commit, build must be done manually via Actions tab. I left the commit in the pull request. Do you prefer this behavior (manual build) or the previous (build on push/PR)?

psqli commented 3 years ago

I just noticed that there are two successful builds after c93792e3cefe53507a387e0f6102e79676e568e3 (just before you reverted #20)

:-)

image

ghost commented 3 years ago

Good catch. That was some unrelated work for distro packagers to vendor all of the Python dependencies, so it would appear this was caused by the build machines not having internet access, which is no longer an issue.

I am fine with merging this, as soon as we fix the other issue: dpkg-name should only be used if explicitly requested by a CLI argument, because it creates packages named only stargate_21.12.3_amd64.deb, which I then have to rename by hand when creating releases to upload for Ubuntu, Debian and Raspbian. But, the daily packages should have a completely different name than the release packages, something like:

stargate-daily-21.11.4-abc1234-amd64.deb

Where abc1234 is the commit hash.