search

start-jsk / rtmros_hironx

hironx controller and applications using rtmros packages
http://wiki.ros.org/rtmros_hironx
10 stars 27 forks source link

add python file to support old api #521

Closed k-okada closed 6 years ago

k-okada commented 6 years ago

suggested by #520

>>> from hironx_ros_bridge import old_api
>>> robot = hironx_client.HIRONX()
felixvd commented 6 years ago

You requested a patch, but I wasn't able to upload it. I left my small changes in the review.

Feel free to let me know what the right way to suggest these changes would have been.

k-okada commented 6 years ago

@felixvd thanks for quick feedback, I expected

git clone http://github.com/k-okada/rtmros_hironx -b  support_old_api 
# change code
git commit -m "fix!!!"
git push felixvd support_old_api

goto https://github.com/start-jsk/rtmros_hironx/compare/ page, push 'compare across forks' link, compare k-okada/support_old_api and felixvd/support_old_api and make pull request

felixvd commented 6 years ago

I made the PR after adding my remote to the cloned repo: git remote add felixvd https://github.com/felixvd/rtmros_hironx.git

Thanks for the explanation.

felixvd commented 6 years ago

For the record, this is the PR with the fix and the comments: https://github.com/k-okada/rtmros_hironx/pull/7

k-okada commented 6 years ago

@felixvd merged