⚠️ This changes deployment behaviour. You now need to run yarn deploy:local to manually deploy the contracts after starting hardhat with yarn chain:local . Previously contracts would get auto-deployed when running yarn chain:local ⚠️
This makes a couple of changes to get the L1 payment flow working. The biggest change was changing our deploy script to not use hardhat-deloy and just use the same logic we use in our contract test. For some reason the contracts deployed via hardhat-deploy were not interacting correctly with the clients. Using the test deployment functions still result in deterministic addresses (as long as the solidity doesn't change) but also don't seem to cause issues when our clients connect to them.
There are also a couple of minor changes to some UserOperation fields (specifying the correct sender, adding some gas limits, removing excess calldata) to get things working based on the existing test.
There are also some minor tweaks to the UI (and some hardcoded values) to use a balance of 5 ETH / 5 ETH instead of 5 wei / 5 wei and display formatted eth values in the UI.
TODO
[x] I don't think we do any nonce management. So every UserOperation is submitted with nonce 0, meaning only the first UserOperation will suceed.
[x] I'm seeing balances change, but not in the way I expect...
[x] Balances are getting updated correctly but it looks like the owner's balance is reduced to 9.000000003473999872 instead of 9. This was due to the gas fees (specified to pay for validation) being refunded to Alice's SCW instead of Irene.
Completes #92
⚠️ This changes deployment behaviour. You now need to run
yarn deploy:local
to manually deploy the contracts after starting hardhat withyarn chain:local
. Previously contracts would get auto-deployed when runningyarn chain:local
⚠️This makes a couple of changes to get the L1 payment flow working. The biggest change was changing our
deploy
script to not usehardhat-deloy
and just use the same logic we use in our contract test. For some reason the contracts deployed viahardhat-deploy
were not interacting correctly with the clients. Using the test deployment functions still result in deterministic addresses (as long as the solidity doesn't change) but also don't seem to cause issues when our clients connect to them.There are also a couple of minor changes to some
UserOperation
fields (specifying the correctsender
, adding some gas limits, removing excess calldata) to get things working based on the existing test.There are also some minor tweaks to the UI (and some hardcoded values) to use a balance of 5 ETH / 5 ETH instead of 5 wei / 5 wei and display formatted eth values in the UI.
TODO
nonce
management. So everyUserOperation
is submitted with nonce0
, meaning only the firstUserOperation
will suceed.9.000000003473999872
instead of9
. This was due to the gas fees (specified to pay for validation) being refunded to Alice's SCW instead of Irene.