search

statisticsnorway / java-vtl

An Open Source Java implementation of the Validation Transformation Language, based on the VTL 1.1 draft specification. The implementation follows the JSR-223 Java Scripting API and exposes a simple connector interface one can implement in order to integrate with any data stores. VTL is a standard language for defining validation and transformation rules (set of operators, their syntax and semantics) for any kind of statistical data.
http://java-vtl.org
Apache License 2.0
21 stars 7 forks source link

VTL parsing should only allow common identifiers in the "on" clause for join operations #106

Closed bjornandre closed 5 years ago

bjornandre commented 5 years ago

CommonIdentifierBindings now doesn't have bindings to the datasets, only the identifier keys. This means that dataset prefix in the 'on' clause in join operations is no longer allowed. This makes a more strict VTL parsing, so one can only use common identifiers, and not just any identifier.

codecov[bot] commented 5 years ago

Codecov Report

Merging #106 into develop will increase coverage by 0.01%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #106      +/-   ##
==========================================
+ Coverage    81.38%   81.4%   +0.01%     
==========================================
  Files          160     160              
  Lines         4465    4469       +4     
  Branches       587     589       +2     
==========================================
+ Hits          3634    3638       +4     
  Misses         652     652              
  Partials       179     179
Impacted Files Coverage Δ
...vtl/script/operations/join/CrossJoinOperation.java 0% <0%> (ø) :arrow_up:
...vtl/script/operations/join/InnerJoinOperation.java 75.92% <100%> (ø) :arrow_up:
...vtl/script/operations/join/OuterJoinOperation.java 80.43% <100%> (ø) :arrow_up:
...ript/operations/join/CommonIdentifierBindings.java 100% <100%> (ø) :arrow_up:
...tl/script/visitors/join/JoinDefinitionVisitor.java 88.88% <100%> (+0.88%) :arrow_up:
.../script/operations/join/AbstractJoinOperation.java 95.71% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bfba32...a511904. Read the comment docs.