search

statisticsnorway / java-vtl

An Open Source Java implementation of the Validation Transformation Language, based on the VTL 1.1 draft specification. The implementation follows the JSR-223 Java Scripting API and exposes a simple connector interface one can implement in order to integrate with any data stores. VTL is a standard language for defining validation and transformation rules (set of operators, their syntax and semantics) for any kind of statistical data.
http://java-vtl.org
Apache License 2.0
21 stars 7 forks source link

Merger mutate left row in buffers #82

Closed hadrienk closed 6 years ago

hadrienk commented 6 years ago

If an operation after tje join opration reduces the number of rows capacity of the datapoints the instances of the left rows in the join buffer are mutated.

There are several places we could create a copy of the left row; merger, spliterator, or cartesian iterator. I chose to put it in the merger to be safe but it is something we should reevaluate later.

codecov[bot] commented 6 years ago

Codecov Report

Merging #82 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
+ Coverage    78.54%   78.54%   +<.01%     
===========================================
  Files          141      141              
  Lines         3570     3571       +1     
  Branches       417      418       +1     
===========================================
+ Hits          2804     2805       +1     
  Misses         643      643              
  Partials       123      123
Impacted Files Coverage Δ
...sb/vtl/script/operations/join/InnerJoinMerger.java 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91d5977...0aff4e6. Read the comment docs.