search

statisticsnorway / java-vtl

An Open Source Java implementation of the Validation Transformation Language, based on the VTL 1.1 draft specification. The implementation follows the JSR-223 Java Scripting API and exposes a simple connector interface one can implement in order to integrate with any data stores. VTL is a standard language for defining validation and transformation rules (set of operators, their syntax and semantics) for any kind of statistical data.
http://java-vtl.org
Apache License 2.0
21 stars 7 forks source link

Fix incorect type in average aggregations #85

Closed hadrienk closed 6 years ago

hadrienk commented 6 years ago

Not an optimal solution but it does the job for now. I also changed the "reduce" implementation to avoid using asMap since it instantiate one object per row.

codecov[bot] commented 6 years ago

Codecov Report

Merging #85 into develop will increase coverage by 0.18%. The diff coverage is 98.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    78.78%   78.96%   +0.18%     
===========================================
  Files          143      144       +1     
  Lines         3596     3637      +41     
  Branches       421      429       +8     
===========================================
+ Hits          2833     2872      +39     
- Misses         641      642       +1     
- Partials       122      123       +1
Impacted Files Coverage Δ
...no/ssb/vtl/script/visitors/AggregationVisitor.java 96.36% <ø> (ø) :arrow_up:
...sb/vtl/script/operations/AggregationOperation.java 97.26% <100%> (+2.26%) :arrow_up:
...b/vtl/script/functions/AggregationAvgFunction.java 100% <100%> (ø) :arrow_up:
...b/vtl/script/functions/AggregationSumFunction.java 100% <100%> (ø) :arrow_up:
...tions/aggregation/AbstractAggregationFunction.java 75% <75%> (ø)
.../src/main/java/no/ssb/vtl/model/DataStructure.java 73.91% <0%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55191ac...4dd48eb. Read the comment docs.