ensure that rarely ran files are compiled on PR

etan-status commented 3 months ago

Add some missing files to isMainModule developer internal builds CI.

github-actions[bot] commented 3 months ago

Unit Test Results

        9 files ±0   1 328 suites ±0 32m 45s :stopwatch: -25s   4 998 tests ±0   4 650 :heavy_check_mark: ±0 348 :zzz: ±0 0 :x: ±0 20 850 runs ±0 20 446 :heavy_check_mark: ±0 404 :zzz: ±0 0 :x: ±0

Results for commit 3d72a9ed. ± Comparison against base commit 31653d58.

:recycle: This comment has been updated with latest results.

tersec commented 3 months ago

The CI job it's using for this mostly isn't bottlenecked currently, but a couple of general possibilities:

use LOG_LEVEL=TRACE to catch potential regressions there which only pop up in the isMainModule code paths
https://github.com/status-im/nimbus-eth2/pull/5669 shows a way to approximately halve build times for code where running the result isn't important, as in these cases, by effectively disabling the C compiler's codegen. It might or might not be worthwhile, depending on targeted compilers. It works for both gcc and clang though, which should be enough on all targeted platforms. The trickiness there, which didn't end up being high enough priority to pursue, resulted from how the build system worked for that part of the CI system. But these raw nim c commands should be amenable to using -fsyntax-only fairly easily. The key flags are -fsyntax-only for the C compiler and --noLinking:on for Nim (because it can't link something which hasn't generated any code)