search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

during proposal duties, perform sync aggregation duties if not received #6384

Closed etan-status closed 3 months ago

etan-status commented 3 months ago

Including sync contributions into a block affects validator rewards. When we have not received aggregate sync contributions, but have seen individual messages, we can produce the contributions locally, improving validator rewards when subscribing to all subnets or when having a non-aggregating attached validator in the sync committee.

etan-status commented 3 months ago

This also makes certain tests a bit less flaky where due to small validator count it can happen that noone is selected as an aggregator.

github-actions[bot] commented 3 months ago

Unit Test Results

         9 files  ±0    1 328 suites  ±0   32m 48s :stopwatch: -46s   4 998 tests ±0    4 650 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 850 runs  ±0  20 446 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit f11e1295. ± Comparison against base commit 6d0c9d37.