search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
546 stars 233 forks source link

Init Fulu fork #6677

Closed agnxsh closed 1 week ago

agnxsh commented 4 weeks ago

adds the Fulu hard fork to nimbus unstable.

github-actions[bot] commented 4 weeks ago

Unit Test Results

       12 files  ±  0    1 814 suites  ±0   55m 31s :stopwatch: + 1m 9s   5 237 tests +  5    4 889 :heavy_check_mark: +  5  348 :zzz: ±0  0 :x: ±0  29 097 runs  +20  28 645 :heavy_check_mark: +20  452 :zzz: ±0  0 :x: ±0 

Results for commit 44531ad2. ± Comparison against base commit a89ee318.

:recycle: This comment has been updated with latest results.

tersec commented 3 weeks ago

https://github.com/status-im/nimbus-eth2/blob/58a34e00a11839a814f364ec4942abe6780a29e9/beacon_chain/spec/datatypes/base.nim#L959-L981 should be updated (also, it should probably get one of the static: doAssert high(ConsensusFork) == ConsensusFork.Fulu checks, because those are exactly to point people to such locations which will continue to compile but be silently incorrect/incomplete until updated.

case statements/expressions do built-in exhaustiveness checking, and for when, one can add the static: doAssert false or similar (raiseAssert, et cetera). But here those don't work/apply, so it just needs to be hand-checked, and it's useful to have a compile-time check for this.

tersec commented 3 weeks ago

https://github.com/status-im/nimbus-eth2/blob/58a34e00a11839a814f364ec4942abe6780a29e9/beacon_chain/spec/eth2_ssz_serialization.nim#L34-L69 needs updating

tersec commented 3 weeks ago

https://github.com/status-im/nimbus-eth2/blob/58a34e00a11839a814f364ec4942abe6780a29e9/beacon_chain/spec/eth2_merkleization.nim#L31-L43 needs updating

tersec commented 3 weeks ago

https://github.com/status-im/nimbus-eth2/blob/58a34e00a11839a814f364ec4942abe6780a29e9/beacon_chain/spec/eth2_merkleization.nim#L31-L43

needs updating

done in https://github.com/status-im/nimbus-eth2/pull/6677/commits/a9c2e69ab2ae7395cce761cf9863fb36cd2d1fc2

tersec commented 3 weeks ago

Why does it modify nim-json-rpc, nim-serialization, and nim-web3? 2024-10-30T18:46:23,104029593+00:00

agnxsh commented 3 weeks ago

Why does it modify nim-json-rpc, nim-serialization, and nim-web3? 2024-10-30T18:46:23,104029593+00:00

will revert/fix post some more cleanups

agnxsh commented 1 week ago

restoring the branch for @Tomi-3-0 and group to branch out from fulu and have EPBS working on Fulu