search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
546 stars 233 forks source link

Fix syncing problem introduced by light forward syncing PR. #6714

Closed cheatfate closed 4 days ago

github-actions[bot] commented 1 week ago

Unit Test Results

       12 files  ±0    1 814 suites  ±0   54m 29s :stopwatch: - 1m 46s   5 238 tests +1    4 890 :heavy_check_mark: +1  348 :zzz: ±0  0 :x: ±0  29 101 runs  +4  28 649 :heavy_check_mark: +4  452 :zzz: ±0  0 :x: ±0 

Results for commit f38ffcf4. ± Comparison against base commit a1577606.

:recycle: This comment has been updated with latest results.

agnxsh commented 5 days ago

@cheatfate is it viable to add to a kzg verification check to checkBlobResponse, atleast to the first sidecar against every block? wanted a take on this

cheatfate commented 5 days ago

@cheatfate is it viable to add to a kzg verification check to checkBlobResponse, atleast to the first sidecar against every block? wanted a take on this

This is not KZG check of blobs - its response sanity check. Actual blobs verification performs here https://github.com/status-im/nimbus-eth2/blob/unstable/beacon_chain/sync/sync_manager.nim#L354-L360