search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
546 stars 233 forks source link

Adopt latest changes to request hash computation #6718

Open etan-status opened 1 day ago

etan-status commented 1 day ago

The requestType of empty lists is no longer part of the requests hash.

tersec commented 1 day ago

Probably best to merge as part of when https://github.com/ethereum/consensus-specs/releases gets a 1.5.0-alpha.9.

github-actions[bot] commented 1 day ago

Unit Test Results

       12 files    1 814 suites   55m 52s :stopwatch:   5 239 tests   4 891 :heavy_check_mark: 348 :zzz: 0 :x: 29 105 runs  28 653 :heavy_check_mark: 452 :zzz: 0 :x:

Results for commit 0660dc97.

etan-status commented 19 hours ago

Tested using https://github.com/ethereum/consensus-specs/pull/3998 -- hashes are the same across all consensus-spec-tests except the one that test 0-length transactions (https://github.com/status-im/nim-eth/pull/744#issuecomment-2492124906). the 0-length tx is invalid anyway so it doesn't matter too much whether it gets rejected for invalid block hash or for being 0-length.