search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
304 stars 79 forks source link

Settings/Wallet/Manage tokens: Implement scroll bar positioning #13365

Open micieslak opened 10 months ago

micieslak commented 10 months ago

Bug Report

Description

The scroll bar overlaps with the content, should be positioned outside, on the right border of the window as in designs.

Initially reported in: https://github.com/status-im/status-desktop/pull/13318#pullrequestreview-1853370526

image

Design for scrollbar behavior here.

Things to consider: With side-by-side preview, the scrollbar should stay in the same position (inside the setting page, not the preview area) when the side-by-side preview is visible. And the scroll should work if the cursor somewhere between delegates and scrollbar

caybro commented 10 months ago

Should be an easy fix, we have the contentWidth available

noeliaSD commented 9 months ago

Here a clarification of the position of the scrollbar from @benjthayer. It's a design in Profile Showcase but it applies as well to the Tokens management pages since it's exactly the same design pattern.

Design:

Screenshot 2024-02-16 at 10 30 04
iurimatias commented 9 months ago

moved to 2.29 due to lack of space in this milestone

noeliaSD commented 7 months ago

Moved to next milestone due to team capacity and priorities.