search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
304 stars 79 forks source link

Browser Plugin - Uniswap - When "Set as Default wallet" is not selected then a connection request should not be triggered on the desktop wallet #16260

Open virginiabalducci opened 2 months ago

virginiabalducci commented 2 months ago

Bug Report

Description

Browser Plugin - When "Set as Default wallet" is not selected then a connection request should not be triggered on the desktop wallet. Is this a bug? If not, can you clarify which is the acceptance criteria for the default option toggled on and off?

I'm not sure if this should be under web team or desktop team scope.

Steps to reproduce

  1. Have the Status browser extension installed
  2. Go to https://app.uniswap.org/
  3. Click on the extension and toggle off "Set as Default wallet"
  4. The site reloads.
  5. Click Connect

Expected behavior

https://www.figma.com/design/1OYKMzU6KTQHQAqDhojk0r/Status-connector?node-id=2141-30138&node-type=INSTANCE&t=IFSWaE9wV7BXwf9H-0 Connection request pop up should not trigger on the Desktop App

Actual behavior

A connection request to Uniswap pop ups on the Desktop wallet even though the "Set as Default wallet" option has been toggled off.

https://github.com/user-attachments/assets/7d3f0e60-8c32-43eb-9552-ba574e64cf10

Additional Information

virginiabalducci commented 2 months ago

cc @alexjba for visibility

alexjba commented 2 days ago

@virginiabalducci I think we can close this as expected based on the discussion here.

https://www.notion.so/Set-Status-Connector-as-default-extension-wallet-35b7bc7b9785468aaccb165c445bc391?d=14a8f96fb65c80249cfb001cd7bf938f&pvs=4