search

status-im / status-protocol-go

Status Protocol implementation in Go
Mozilla Public License 2.0
0 stars 1 forks source link

Add ens name verification #91

Closed cammellos closed 4 years ago

cammellos commented 4 years ago

Add ENS verification to status-protocol-go.

I have added a test, but is only run if RPC_ENDPOINT is set in the enviroment variable, that's because is fairly flaky due to hitting the quota limit + it's an online test, but it's still valuable imo as it check e2e.

Also fixes a few issues with the move to different types; 1) JSON was not marshalled correctly as some of the fields used hexutil.bytes 2) Re-introduced method used by status-react, but using the new types now.

cammellos commented 4 years ago

@adambabik ready to be reviewed again, the only things I have left unresolved is: 1) Geth change in go.mod, not sure but it throws an error with the previous version 2) Test for ENS

I would address both of this issue in a separate PR, as I would like to get this in and verify with status-react, if you are ok with it. thanks!

adambabik commented 4 years ago

@cammellos I pushed one change.

github.com/status-im/status-go v0.34.0-beta.0 // indirect is included in go.mod because our fork of go-ethereum requires it, for example:

github.com/ethereum/go-ethereum/accounts/keystore/key.go:   "github.com/status-im/status-go/extkeys"
replace github.com/NaySoftware/go-fcm => github.com/status-im/go-fcm v1.0.0-status

was needed because otherwise it couldn't find the tag.

replace github.com/ethereum/go-ethereum v1.9.5 => github.com/status-im/go-ethereum v1.9.5-status.4

is brought back and tests pass.