search

status-im / status.im-old

Main Status.im webpage.
http://status.im/
2 stars 1 forks source link

Add fastlane iframe to success page #36

Closed noman-land closed 6 years ago

noman-land commented 6 years ago

At behest of Jonny.

image image image image

@chadyj @oskarth

chadyj commented 6 years ago

The iframe looks good, but the copy needs to be changed to instruct iOS users to fill out the form.

oskarth commented 6 years ago

What's the reason for using heroku iframe? Is there no native JS we can include for form submission?

BTW @noman-land you can request reviews directly in GH interface to the right.

chadyj commented 6 years ago

It isn't just a form, but a rails app that runs Fastlane that enables the iTC/Testflight integration. Without Boarding you would need to create an app that calls Fastlane/Spaceship directly, plus a server to run it. Fastlane doesn't support a HTML/JS option.

More info here https://github.com/fastlane/boarding

oskarth commented 6 years ago

@chadyj Gotcha, cool. Misunderstood what it was doing, thought it was jut a form calling Fastlane API with some token :)

oskarth commented 6 years ago

Where is the actual Heroku setup? @v2nek should probably be aware of this.

chadyj commented 6 years ago

Where is the actual Heroku setup? @v2nek should probably be aware of this.

He is aware :) https://status-im.slack.com/archives/C8M1Z25J8/p1516071116000149

noman-land commented 6 years ago

Okay guys copy (and screenshots) updated. Do we want to get rid of the "Status -- Ethereum. Anywhere." heading? That's included inside the iframe and feels a bit superfluous (and doesn't match style).

noman-land commented 6 years ago

@oskarth It seems I don't have privs to add reviewers on this repo :/

chadyj commented 6 years ago

Any changes to the iframe can be done here! https://github.com/status-im/boarding

chadyj commented 6 years ago

@oskarth, @j-zerah approved this. Please merge when you can.