search

stavro / arc_ecto

An integration with Arc and Ecto.
255 stars 149 forks source link

Todo: Support Ecto 3 #98

Closed mmartinson closed 6 years ago

mmartinson commented 6 years ago

Ecto 3 is coming in the next couple days and with it the recommended upgrade path for those using it for database interaction is to change dependency from ecto to ecto_sql.

I think to support backwards compatibly for presumably a long time we'll want to introduce an optional dependency.

Reference commit and announcement

idyll commented 6 years ago

One of the changes that's needed is in cast_attachments

The allowed params in:

cast(changeset_or_data, arc_params, allowed)

are converted into strings. Which triggers all sorts of warnings because they should be atoms.

nathany commented 6 years ago

It seems that the test suite doesn't require ecto_sql.

101 amends #99 for Ecto 3.0 final. @tarzan resolved the warnings.

Do you want to support Ecto 2.x and 3.x simultaneously, or just release a new major version that requires Ecto 3? [people can always use an old version of arc_ecto]

williamweckl commented 6 years ago

Any updates on this?

dbernheisel commented 6 years ago

I think this issue is resolved with https://github.com/stavro/arc_ecto/pull/103

williamweckl commented 6 years ago

@dbernheisel Yes it is!