stayallive / wp-sentry

A (unofficial) WordPress plugin reporting PHP and JavaScript errors to Sentry.
https://wordpress.org/plugins/wp-sentry-integration/
MIT License
300 stars 48 forks source link

Automated updates for Sentry SDKs #143

Closed androidacy-user closed 1 year ago

androidacy-user commented 1 year ago

Here we are again, the JavaScript SDK is 7+ versions behind, To be honest, Sentry updates quite frequently, so perhaps some automated workflow to update the JS/PHP SDKs would be a viable option.

Just a thought for consideration, especially as it would mean less time for you to spend updating the SDKs 😄

stayallive commented 1 year ago

Hi @androidacy-user, I am not comfortable with automating that task. But sometimes that means the updates will take a beat to trickle down. Is there something specific you are waiting for?

Edit: https://github.com/stayallive/wp-sentry/releases/tag/v6.2.0 is out now with all the recent versions :)

androidacy-user commented 1 year ago

Hi @androidacy-user, I am not comfortable with automating that task. But sometimes that means the updates will take a beat to trickle down. Is there something specific you are waiting for?

Edit: https://github.com/stayallive/wp-sentry/releases/tag/v6.2.0 is out now with all the recent versions :)

You could either automate that and test so all you have to do is rubber stamp the release or separate the wordpress specific logic from the SDKs - i.e., the browser tracing file should load the actual sdk, not include the actual SDK. The sentry team moves fast and we're storing at an alert in our Sentry dashboard for weeks sometimes telling us (very bossily, too!) to update our SDKs. Either way, at least partially automating updating the upstream SDKs would be helpful on both ends, I think.

My honest advice is the second. It would be easier to maintain for you, and ensure we the user get sentry updates fastr, bar sentry having breaking changes.

androidacy-user commented 1 year ago

My vague idea would be:

stayallive commented 1 year ago

Thanks, I'll take this into consideration and might implement this in the future.