codecov-io
commented
3 years ago Codecov Report
Merging #149 (72adeae) into 43-feat-uyuni_support (7c8bf52) will increase coverage by
5.91%. The diff coverage is52.73%.
@@ Coverage Diff @@
## 43-feat-uyuni_support #149 +/- ##
=========================================================
+ Coverage 14.93% 20.85% +5.91%
=========================================================
Files 20 22 +2
Lines 2176 2345 +169
=========================================================
+ Hits 325 489 +164
- Misses 1851 1856 +5 | Impacted Files | Coverage Δ | |
|---|---|---|
| katprep/__init__.py | 25.30% <ø> (+4.80%) |
:arrow_up: |
| katprep/maintenance.py | 0.00% <0.00%> (ø) |
|
| katprep/populate.py | 0.00% <0.00%> (ø) |
|
| katprep/report.py | 0.00% <0.00%> (ø) |
|
| katprep/monitoring/__init__.py | 14.28% <7.69%> (-85.72%) |
:arrow_down: |
| katprep/management/__init__.py | 12.50% <12.50%> (ø) |
|
| katprep/monitoring/nagios.py | 19.35% <26.31%> (-1.32%) |
:arrow_down: |
| katprep/monitoring/icinga2.py | 19.23% <50.00%> (ø) |
|
| katprep/reports.py | 69.23% <69.23%> (ø) |
|
| katprep/AuthContainer.py | 88.99% <83.33%> (+0.41%) |
:arrow_up: |
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7c8bf52...72adeae. Read the comment docs.
okin
stdevel
This PR modifies the internal workflow to use instances of hosts or hostgroups that will be passed to the functions instead of always looking up an ID and passing it alongside the type of object.
It uses factories for creating the required clients.
It provides a stable interface for getting the identifiers used for monitoring clients.
It also has preparations made that will allow us to read a report and convert the data into the newer classes but there isn't yet support for writing them to a report.