search

stdevel / katprep

Python toolkit for automating system maintenance and generating patch reports along with Foreman/Katello and Red Hat Satellite 6.x
GNU General Public License v3.0
35 stars 6 forks source link

Fix broken Authconfig in Python 3.x #151

Closed stdevel closed 3 years ago

stdevel commented 3 years ago

The patches applied already help with encypting the files, but reading/decrypting doesn't work, yet.

codecov-io commented 3 years ago

Codecov Report

Merging #151 (e957319) into master (c4fa896) will increase coverage by 2.98%. The diff coverage is 81.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   12.33%   15.31%   +2.98%     
==========================================
  Files          20       20              
  Lines        1986     1991       +5     
==========================================
+ Hits          245      305      +60     
+ Misses       1741     1686      -55
Impacted Files Coverage Δ
katprep/__init__.py 20.83% <0.00%> (-0.36%) :arrow_down:
katprep/authconfig.py 0.00% <0.00%> (ø)
katprep/AuthContainer.py 90.00% <87.50%> (+59.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4fa896...e957319. Read the comment docs.

okin commented 3 years ago

@stdevel I fixed the container to work with Python 3. There is no backwards compat the Py 2.

Tested the CLI and it did work for me.

okin commented 3 years ago

@stdevel wouldn't it be more benefical right now if the changes land in the branch for Uyuni support (43-...)?

stdevel commented 3 years ago

@stdevel wouldn't it be more benefical right now if the changes land in the branch for Uyuni support (43-...)?

Good idea - just changed the base.

Thanks for your work - is your PR considered ready now?

okin commented 3 years ago

Thanks for your work - is your PR considered ready now?

Yes - worked in all my tests.