stdevel commented 3 years ago

See also issue #43

stdevel commented 3 years ago

I think you can also add support for Uyuni in README.md :)

Done

What are the multiple requirements files (requirements_uyuni.yml & requirements_uyuniclient.yml) for?

It is used as Ansible preparation for the Vagrantboxes. The Uyuni server needs a specific role while the client doesn't need it so we can save time by supplying a different (currently empty, but this might change) requirements file.

In the modules that provide a CLI interface only ForemanAPIClient is instantiated. Once there is a common interface these occurances should be replaced by using the factory katprep.management.get_management_client.

Good idea - I'm pinging you about the implementation today. 👍🏻

codecov-commenter commented 3 years ago

Codecov Report

Merging #155 (e6e96a8) into master (c8e4b78) will increase coverage by 8.65%. The diff coverage is n/a.

:exclamation: Current head e6e96a8 differs from pull request most recent head b1e35b1. Consider uploading reports for the commit b1e35b1 to get more accurate results

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   12.33%   20.99%   +8.65%     
==========================================
  Files          20       22       +2     
  Lines        1986     2334     +348     
==========================================
+ Hits          245      490     +245     
- Misses       1741     1844     +103

Impacted Files	Coverage Δ
katprep/AuthContainer.py	`88.99% <ø> (+58.06%)`	:arrow_up:
katprep/__init__.py	`25.30% <ø> (+4.11%)`	:arrow_up:
katprep/authconfig.py	`0.00% <ø> (ø)`
katprep/exceptions.py	`100.00% <ø> (ø)`
katprep/host.py	`100.00% <ø> (ø)`
katprep/maintenance.py	`0.00% <ø> (ø)`
katprep/management/__init__.py	`17.64% <ø> (-82.36%)`	:arrow_down:
katprep/management/base.py	`69.69% <ø> (ø)`
katprep/management/libvirt.py	`0.00% <ø> (ø)`
katprep/management/uyuni.py	`14.16% <ø> (ø)`
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8e4b78...b1e35b1. Read the comment docs.

stdevel / katprep

WIP: Implement Uyuni support #155

Codecov Report