search

stealjs / steal

Gets JavaScript
https://stealjs.com
MIT License
1.37k stars 521 forks source link

Fix security vulnerability introduced by eslint<4.18.2 #1503

Closed m-mujica closed 5 years ago

m-mujica commented 5 years ago

Ran into some issues with the files lookup, it seems passing only the directories is better than globbing. I intentionally added a param reassign to make sure eslint was indeed working.

npm run lint

> steal@2.2.2 lint /Users/mmujica/Projects/steal
> eslint src ext

/Users/mmujica/Projects/steal/src/json/json.js
  4:2  error  Assignment to function parameter 'loader'  no-param-reassign

✖ 1 problem (1 error, 0 warnings)
m-mujica commented 5 years ago

I'm sure there is no issues with me merge this PR 💅