Log request bodies as separate logs, add some basic redaction

steamclock / netable

A Swift library for encapsulating network APIs using Codable in a type-oriented way.

MIT License

99 stars 3 forks source link

Log request bodies as separate logs, add some basic redaction #81

Closed brendanlensink closed 3 years ago

brendanlensink commented 3 years ago

Adds a new log event, requestBody that accepts a [String: String] dictionary to print out.
Adds a new optional field to Request, safeParameterKeys that accepts a set of strings that are safe to print to the console.
Also adds a computed variable, safeParameters that returns a dictionary of the parameters with any values not defined as safe replaced with

Also bumped the version number to 1.0 in anticipation of our next release.

brendanlensink commented 3 years ago

Updated:

Added a disableLogRedaction option to the config object
Changed safeParameters to unredactedParameters

brendanlensink commented 3 years ago

After some more thinking, I think I'm okay with being a little opinionated on having redaction enabled by default, as long as you're able to turn it off globally easily.

Also great point about en/disable, swapped to enableLogRedaction.